OSDN Git Service

perf tools: Fix snprint warnings for gcc 8
authorJiri Olsa <jolsa@kernel.org>
Mon, 19 Mar 2018 08:29:01 +0000 (09:29 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 19 Mar 2018 13:00:43 +0000 (10:00 -0300)
commit77f18153c080855e1c3fb520ca31a4e61530121d
treee667525893ac4fe6eadb83c02b3381fb950dfa7a
parenta08f6dd4190e90dc7b013435acb66770f117e8b0
perf tools: Fix snprint warnings for gcc 8

With gcc 8 we get new set of snprintf() warnings that breaks the
compilation, one example:

  tests/mem.c: In function ‘check’:
  tests/mem.c:19:48: error: ‘%s’ directive output may be truncated writing \
        up to 99 bytes into a region of size 89 [-Werror=format-truncation=]
    snprintf(failure, sizeof failure, "unexpected %s", out);

The gcc docs says:

 To avoid the warning either use a bigger buffer or handle the
 function's return value which indicates whether or not its output
 has been truncated.

Given that all these warnings are harmless, because the code either
properly fails due to uncomplete file path or we don't care for
truncated output at all, I'm changing all those snprintf() calls to
scnprintf(), which actually 'checks' for the snprint return value so the
gcc stays silent.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Link: http://lkml.kernel.org/r/20180319082902.4518-1-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-script.c
tools/perf/tests/attr.c
tools/perf/tests/mem.c
tools/perf/tests/pmu.c
tools/perf/util/cgroup.c
tools/perf/util/parse-events.c
tools/perf/util/pmu.c