OSDN Git Service

Register Ime consumer only when insets are enabled.
authorTarandeep Singh <tarandeep@google.com>
Tue, 23 Apr 2019 23:25:38 +0000 (16:25 -0700)
committerTarandeep Singh <tarandeep@google.com>
Wed, 24 Apr 2019 06:29:35 +0000 (06:29 +0000)
commit7928f7cd4deda9dfe933ce2df12f3e36f7009267
tree3e9c082d40d6a94c1f04e37c1aec7ad99ac24200
parenta37cd55e10ab0785b986a39ed90846b3bd4c914a
Register Ime consumer only when insets are enabled.

As of today we register Ime consumer in IMM onWindowGainedFocus().
However, it does nothing functionally when ViewRootImpl#sNewInsetsMode is disabled.
This CL adds a check to not register consumer at the first place.

This may also be causing a leak. Added a TODO to revisit that before we
enable the flag.

Bug: 131181940
Test: atest ViewRootImpl
Test: atest InsetsController
Change-Id: I6b2b62d10670d63edafeb1b24c25b26c7721f3ad
core/java/android/view/ViewRootImpl.java