OSDN Git Service

quorum: Set sectors-count to 0 when reporting a flush error
authorAlberto Garcia <berto@igalia.com>
Mon, 7 Aug 2017 12:36:58 +0000 (15:36 +0300)
committerKevin Wolf <kwolf@redhat.com>
Tue, 8 Aug 2017 12:37:00 +0000 (14:37 +0200)
commit795be0621a643f3d103d112dfcbddee2992f5035
tree717a243713c10e5f44c81a15feb98c14bf17493b
parent53dd4015acb48bad5aee5ba707848370dc442077
quorum: Set sectors-count to 0 when reporting a flush error

The QUORUM_REPORT_BAD event has fields to report the sector in which
the error was detected and the number of affected sectors starting
from that one. This is important for read and write errors, but not
for flush errors.

For flush errors the current code reports the total size of the disk
image. That is however not useful information in this case. Moreover,
the bdrv_getlength() call can fail, and there's no good way of
handling that failure.

Since we're reporting useless information and we cannot even guarantee
to do it in a consistent way, this patch changes the code to report 0
instead in all cases.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/quorum.c