OSDN Git Service

svga: change svga_destroy_shader_variant() to return void
authorBrian Paul <brianp@vmware.com>
Tue, 9 Oct 2018 14:55:46 +0000 (08:55 -0600)
committerBrian Paul <brianp@vmware.com>
Tue, 9 Oct 2018 17:17:14 +0000 (11:17 -0600)
commit797e34f65879039aecc0a677c44af0a1185edfd7
treeab83b7f7559a43e7adb04cfa9ddccbaaec5a8f80
parentb781688636a42be2120047b868abc9bab823acbf
svga: change svga_destroy_shader_variant() to return void

svga_destroy_shader_variant() itself flushes and retries the command
if there's a failure.  So no need for the callers to do it.  Other
callers of the function were already ignoring the return value.

This also fixes a corner-case double-free reported by Coverity
(and reported by Dave Airlie).

Tested with various OpenGL apps.

Reviewed-by: Charmaine Lee <charmainel@vmware.com>
src/gallium/drivers/svga/svga_pipe_fs.c
src/gallium/drivers/svga/svga_pipe_gs.c
src/gallium/drivers/svga/svga_pipe_vs.c
src/gallium/drivers/svga/svga_shader.c
src/gallium/drivers/svga/svga_shader.h