OSDN Git Service

apparmor: fix unsigned len comparison with less than zero
authorColin Ian King <colin.king@canonical.com>
Thu, 27 Jun 2019 13:09:04 +0000 (14:09 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 Jan 2020 18:13:08 +0000 (19:13 +0100)
commit79a1eae9e433357390c03ed3ed57037d88a73554
treee6d7b49b7463162a33b957e236308378933cd935
parentdcf1f67c6db2d4c7521e4a19349c203c50b11aa7
apparmor: fix unsigned len comparison with less than zero

[ Upstream commit 00e0590dbaec6f1bcaa36a85467d7e3497ced522 ]

The sanity check in macro update_for_len checks to see if len
is less than zero, however, len is a size_t so it can never be
less than zero, so this sanity check is a no-op.  Fix this by
making len a ssize_t so the comparison will work and add ulen
that is a size_t copy of len so that the min() macro won't
throw warnings about comparing different types.

Addresses-Coverity: ("Macro compares unsigned to 0")
Fixes: f1bd904175e8 ("apparmor: add the base fns() for domain labels")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
security/apparmor/label.c