OSDN Git Service

media: atmel-isc: avoid returning a random value at isc_parse_dt()
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 1 Nov 2017 12:54:58 +0000 (08:54 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 11 Dec 2017 18:04:50 +0000 (13:04 -0500)
commit79c5453d3e3e7de9e5ce5c88af29b34688dd0469
tree5b219cc95205b128ca3f1e8d447ddc9190cd66ff
parent910b0797fa9e8af09c44a3fa36cb310ba7a7218d
media: atmel-isc: avoid returning a random value at isc_parse_dt()

As warned by smatch:
drivers/media/platform/atmel/atmel-isc.c:2097 isc_parse_dt() error: uninitialized symbol 'ret'.

The problem here is that of_graph_get_next_endpoint() can
potentially return NULL on its first pass, with would make
it return a random value, as ret is not initialized.

While here, use while(1) instead of for(; ;), as while is
the preferred syntax for such kind of loops.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/atmel/atmel-isc.c