OSDN Git Service

NFS: Fix an RCU lock leak in nfs4_refresh_delegation_stateid()
authorTrond Myklebust <trondmy@gmail.com>
Thu, 31 Oct 2019 22:40:33 +0000 (18:40 -0400)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Fri, 1 Nov 2019 15:03:56 +0000 (11:03 -0400)
commit79cc55422ce99be5964bde208ba8557174720893
tree4158ef1314feac72c6d39d21564860a137e2abde
parentbe3df3dd4c70ee020587a943a31b98a0fb4b6424
NFS: Fix an RCU lock leak in nfs4_refresh_delegation_stateid()

A typo in nfs4_refresh_delegation_stateid() means we're leaking an
RCU lock, and always returning a value of 'false'. As the function
description states, we were always supposed to return 'true' if a
matching delegation was found.

Fixes: 12f275cdd163 ("NFSv4: Retry CLOSE and DELEGRETURN on NFS4ERR_OLD_STATEID.")
Cc: stable@vger.kernel.org # v4.15+
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/delegation.c