OSDN Git Service

Input: Fix memory leak in psxpad_spi_probe
authorNavid Emamdoost <navid.emamdoost@gmail.com>
Thu, 21 Nov 2019 20:01:11 +0000 (14:01 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 13 Dec 2019 07:52:40 +0000 (08:52 +0100)
commit79f08904592c18921969cfcff851b627d69da7bf
tree0565e93989d16478b0a649ae68f23f6ede88c3a8
parent7c193ed6e1a1276a1b3f6b8b0430cb2892e31740
Input: Fix memory leak in psxpad_spi_probe

In the implementation of psxpad_spi_probe() the allocated memory for
pdev is leaked if psxpad_spi_init_ff() or input_register_polled_device()
fail. The solution is using device managed allocation, like the one used
for pad. Perform the allocation using
devm_input_allocate_polled_device().

Fixes: 8be193c7b1f4 ("Input: add support for PlayStation 1/2 joypads connected via SPI")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/input/joystick/psxpad-spi.c