OSDN Git Service

drm: Initialize struct drm_crtc_state.no_vblank from device settings
authorThomas Zimmermann <tzimmermann@suse.de>
Wed, 29 Jan 2020 12:05:17 +0000 (13:05 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Thu, 30 Jan 2020 07:57:12 +0000 (08:57 +0100)
commit7beb691f1e6f349c9df3384a85e7a53c5601aaaf
treee36f1fff3b1c02f362a5efee6a0416b63e14b707
parent86a9360be144c9c981c48f8e5b2214179cb53dc5
drm: Initialize struct drm_crtc_state.no_vblank from device settings

At the end of a commit, atomic helpers can generate a fake VBLANK event
automatically. Originally implemented for writeback connectors, the
functionality can be used by any driver and/or hardware without proper
VBLANK interrupt.

The patch updates the documentation to make this behaviour official:
settings struct drm_crtc_state.no_vblank to true enables automatic
generation of fake VBLANK events.

The new interface drm_dev_has_vblank() returns true if vblanking has
been initialized for a device, or false otherwise. Atomic helpers use
this function when initializing no_vblank in the CRTC state in
drm_atomic_helper_check_modeset(). If vblanking has been initialized
for a device, no_blank is disabled. Otherwise it's enabled. Hence,
atomic helpers will automatically send out fake VBLANK events with any
driver that did not initialize vblanking.

v5:
* more precise documentation and commit message
v4:
* replace drm_crtc_has_vblank() with drm_dev_has_vblank()
* add drm_dev_has_vblank() in this patch
* move driver changes into separate patches
v3:
* squash all related changes patches into this patch

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200129120531.6891-2-tzimmermann@suse.de
drivers/gpu/drm/drm_atomic_helper.c
drivers/gpu/drm/drm_vblank.c
include/drm/drm_crtc.h
include/drm/drm_simple_kms_helper.h
include/drm/drm_vblank.h