OSDN Git Service

scsi: bnx2fc: fix bnx2fc_cmd refcount imbalance in send_srr
authorLin Yi <teroincn@163.com>
Tue, 25 Jun 2019 02:35:29 +0000 (10:35 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 27 Jun 2019 02:43:02 +0000 (22:43 -0400)
commit7bfe5ae57c803dd529aaf6feb32c3b49ebff66bd
tree0e9c5594911a642dc4a3c3bb149638b4208e548d
parent177709c0702e7351dae3b9b4f9de3140a9ee3a06
scsi: bnx2fc: fix bnx2fc_cmd refcount imbalance in send_srr

If cb_arg alloc failed, we can't release the struct orig_io_req refcount
before we take its refcount. As Saurav said, move the srr_err label down
to avoid unnecessary refcount release and nullptr free.

Signed-off-by: Lin Yi <teroincn@163.com>
Acked-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/bnx2fc/bnx2fc_els.c