OSDN Git Service

scsi: hisi_sas: Relocate call to hisi_sas_debugfs_exit()
authorXiang Chen <chenxiang66@hisilicon.com>
Tue, 12 Nov 2019 09:30:58 +0000 (17:30 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 13 Nov 2019 03:21:34 +0000 (22:21 -0500)
commit7c0ecd40c31246a2d0de81879966436ff07505a4
tree96308ce3bbff6904b232d2c67782e22e8b4876fc
parent547fde8b5a1923050f388caae4f76613b5a620e0
scsi: hisi_sas: Relocate call to hisi_sas_debugfs_exit()

Currently we call function hisi_sas_debugfs_exit() to remove debugfs_dir
before freeing interrupt irqs and destroying workqueue in the driver remove
path.

If a dump is triggered before function hisi_sas_debugfs_exit() but
debugfs_work may be called after it, so it may refer to already removed
debugfs_dir which will cause NULL pointer dereference.

To avoid it, put function hisi_sas_debugfs_exit() after free_irqs and
destroy workqueue when removing hisi_sas driver.

Link: https://lore.kernel.org/r/1573551059-107873-4-git-send-email-john.garry@huawei.com
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c