OSDN Git Service

ext4: fix potential NULL pointer dereference in ext4_fill_super()
authorLukas Czerner <lczerner@redhat.com>
Wed, 19 Jan 2022 13:02:09 +0000 (14:02 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 3 Feb 2022 15:57:44 +0000 (10:57 -0500)
commit7c268d4ce2d3761f666a9950b029c8902bfab710
treefb0739349fdd94bc701740fa59cf79a79727410b
parent4f98186848707f530669238d90e0562d92a78aab
ext4: fix potential NULL pointer dereference in ext4_fill_super()

By mistake we fail to return an error from ext4_fill_super() in case
that ext4_alloc_sbi() fails to allocate a new sbi. Instead we just set
the ret variable and allow the function to continue which will later
lead to a NULL pointer dereference. Fix it by returning -ENOMEM in the
case ext4_alloc_sbi() fails.

Fixes: cebe85d570cf ("ext4: switch to the new mount api")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Link: https://lore.kernel.org/r/20220119130209.40112-1-lczerner@redhat.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/super.c