OSDN Git Service

arm/{bcm2835,fsl-imx25,fsl-imx6}: Fix realize error API violations
authorMarkus Armbruster <armbru@redhat.com>
Tue, 30 Jun 2020 09:03:50 +0000 (11:03 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 2 Jul 2020 09:54:47 +0000 (11:54 +0200)
commit7cd1c981eb497de3efd6707d7ccf3fb756c2350f
tree614502a2f865a43b5ad3ff9757025dd7d9a845ad
parent17d5d49a4e877b08ebf82aa33b349176281e68a3
arm/{bcm2835,fsl-imx25,fsl-imx6}: Fix realize error API violations

The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL.  Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.

bcm2835_peripherals_realize(), fsl_imx25_realize() and
fsl_imx6_realize() are wrong that way: they pass &err to
object_property_set_uint() and object_property_set_bool() without
checking it, and then to sysbus_realize().  Harmless, because the
former can't actually fail here.

Fix by passing &error_abort instead.

Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Andrew Baumann <Andrew.Baumann@microsoft.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Jean-Christophe Dubois <jcd@tribudubois.net>
Cc: qemu-arm@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-26-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
hw/arm/bcm2835_peripherals.c
hw/arm/fsl-imx25.c
hw/arm/fsl-imx6.c