OSDN Git Service

(root) / android-x86 / packages-apps-Settings.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 040124c) | patch
Fix "Play media to" popup close issue when screen rotate
authorJames Lu <lujames@google.com>
Fri, 21 Dec 2018 12:23:53 +0000 (20:23 +0800)
committerJames Lu <lujames@google.com>
Thu, 10 Jan 2019 09:09:46 +0000 (17:09 +0800)
commit7ce23b578a1b5d229114cadea2fe4a6c6043bbcf
treee50c4dd6802b830f19aaf269ef8c24b1d4efff3ctree | snapshot
parent040124cca25d7f7ec829d3454a1eb5b1b5a1d80ccommit | diff
Fix "Play media to" popup close issue when screen rotate

- Avoid calling getListPreference() in onDialogClose() everytime.
  Due to exception in onDialogClose(). Move preference declaration into if condition.
- Add test case for crash case.

Bug: 119744621
Test: make -j50 RunSettingsRoboTests ROBOTEST_FILTER=UpdatableListPreferenceDialogFragmentTest
Change-Id: Ia20b8289a5863136ea74e02e32b537f6967474e8
src/com/android/settings/widget/UpdatableListPreferenceDialogFragment.java diff | blob | history
tests/robotests/src/com/android/settings/widget/UpdatableListPreferenceDialogFragmentTest.java diff | blob | history
packages/apps/Settings
About OSDN
Find Software
Develop Software
Help