OSDN Git Service

tty: serial: samsung: Correct clock selection logic
authorJonathan Bakker <xc-racer2@live.ca>
Sat, 9 May 2020 01:34:33 +0000 (18:34 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 May 2020 10:24:15 +0000 (12:24 +0200)
commit7d31676a8d91dd18e08853efd1cb26961a38c6a6
tree418d4fce8f77038afdd6a95324ee8077b85acf9c
parentad406341bdd7d22ba9497931c2df5dde6bb9440e
tty: serial: samsung: Correct clock selection logic

Some variants of the samsung tty driver can pick which clock
to use for their baud rate generation.  In the DT conversion,
a default clock was selected to be used if a specific one wasn't
assigned and then a comparison of which clock rate worked better
was done.  Unfortunately, the comparison was implemented in such
a way that only the default clock was ever actually compared.
Fix this by iterating through all possible clocks, except when a
specific clock has already been picked via clk_sel (which is
only possible via board files).

Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/BN6PR04MB06604E63833EA41837EBF77BA3A30@BN6PR04MB0660.namprd04.prod.outlook.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/samsung_tty.c