OSDN Git Service

irqchip/imx-irqsteer: Fix of_property_read_u32() error handling
authorArnd Bergmann <arnd@arndb.de>
Mon, 4 Mar 2019 20:02:18 +0000 (21:02 +0100)
committerMarc Zyngier <marc.zyngier@arm.com>
Mon, 4 Mar 2019 21:12:29 +0000 (21:12 +0000)
commit7d3a5eb78e3614b025389d2cd89d6d85e91f5549
treec424177f844619880f7a2fe6d1bca20393e74973
parent28528fca4908142bd1a3247956cba56c9c667d71
irqchip/imx-irqsteer: Fix of_property_read_u32() error handling

gcc points out that irqs_num is not initialized when of_property_read_u32()
is an empty stub function:

                 Included from drivers/irqchip/irq-imx-irqsteer.c:7:
drivers/irqchip/irq-imx-irqsteer.c: In function 'imx_irqsteer_probe':
include/uapi/linux/kernel.h:13:49: error: 'irqs_num' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The same can actually happen with CONFIG_OF=y as well, though we don't
get a warning then.

Add error checking here that lets the code deal with missing or
invalid properties as well as avoid the warning.

Fixes: 28528fca4908 ("irqchip/imx-irqsteer: Add multi output interrupts support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-imx-irqsteer.c