OSDN Git Service

perf probe: Show better error message when failed to find variable
authorHe Kuang <hekuang@huawei.com>
Mon, 11 May 2015 09:25:04 +0000 (09:25 +0000)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 12 May 2015 12:59:50 +0000 (09:59 -0300)
commit7d5eaba9b33682b734e3a79c21c4a9a5f91624b1
treea8dcdfd13dde51b48d41cb1c6747e98ae326db34
parent349e8d2611316cce11c0b9d0830ebb585c9b82b8
perf probe: Show better error message when failed to find variable

Indicate to check variable location range in error message when we got
failed to find the variable.

Before this patch:

  $ perf probe --add 'generic_perform_write+118 bytes'
  Failed to find the location of bytes at this address.
   Perhaps, it has been optimized out.
    Error: Failed to add events.

After this patch:

  $ perf probe --add 'generic_perform_write+118 bytes'
  Failed to find the location of the 'bytes' variable at this address.
   Perhaps it has been optimized out.
   Use -V with the --range option to show 'bytes' location range.
    Error: Failed to add events.

Signed-off-by: He Kuang <hekuang@huawei.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1431336304-16863-3-git-send-email-hekuang@huawei.com
[ Improve the error message based on lkml thread ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/probe-finder.c