OSDN Git Service

net/mlx5: Devcom, only use devcom after NULL check in mlx5_devcom_send_event()
authorLi Zetao <lizetao1@huawei.com>
Mon, 14 Aug 2023 07:23:42 +0000 (15:23 +0800)
committerSaeed Mahameed <saeedm@nvidia.com>
Mon, 21 Aug 2023 17:55:17 +0000 (10:55 -0700)
commit7d7c6e8c5fe4e8cceea7f66e93cee1c951670836
tree4e5154317180af10c821a6b6fa59e5045a9c4f01
parent95c337cce0e11d06a715da73e6796ade9216637f
net/mlx5: Devcom, only use devcom after NULL check in mlx5_devcom_send_event()

There is a warning reported by kernel test robot:

smatch warnings:
drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c:264
mlx5_devcom_send_event() warn: variable dereferenced before
IS_ERR check devcom (see line 259)

The reason for the warning is that the pointer is used before check, put
the assignment to comp after devcom check to silence the warning.

Fixes: 88d162b47981 ("net/mlx5: Devcom, Infrastructure changes")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202308041028.AkXYDwJ6-lkp@intel.com/
Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c