OSDN Git Service

fbdev: Improve performance of sys_fillrect()
authorThomas Zimmermann <tzimmermann@suse.de>
Wed, 23 Feb 2022 19:38:00 +0000 (20:38 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Wed, 2 Mar 2022 19:20:34 +0000 (20:20 +0100)
commit7dbc515f5ca4b7867e34c0c4379591cb8b47d64f
tree7448c0f6dbb30b0cc90faf88fab968c59db0bc56
parent81d9d7f8bb8bacd96b2e0e5779e3fba9e86da73f
fbdev: Improve performance of sys_fillrect()

Improve the performance of sys_fillrect() by using word-aligned
32/64-bit mov instructions. While the code tried to implement this,
the compiler failed to create fast instructions. The resulting
binary instructions were even slower than cfb_fillrect(), which
uses the same algorithm, but operates on I/O memory.

A microbenchmark measures the average number of CPU cycles
for sys_fillrect() after a stabilizing period of a few minutes
(i7-4790, FullHD, simpledrm, kernel with debugging). The value
for CFB is given as a reference.

  sys_fillrect(), new:  26586 cycles
  sys_fillrect(), old: 166603 cycles
  cfb_fillrect():       41012 cycles

In the optimized case, sys_fillrect() is now ~6x faster than before
and ~1.5x faster than the CFB implementation.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220223193804.18636-2-tzimmermann@suse.de
drivers/video/fbdev/core/sysfillrect.c