OSDN Git Service

OPP: Fix potential null ptr dereference in dev_pm_opp_get_required_pstate()
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Fri, 21 Jul 2023 12:46:33 +0000 (18:16 +0530)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 24 Jul 2023 08:01:17 +0000 (13:31 +0530)
commit7ddd8deb1c3c0363a7e14fafb5df26e2089a69a5
treefa737024ea531c153c3a34299d015e4cd7bd0d31
parent746de8255076c9924ffa51baad9822adddccb94e
OPP: Fix potential null ptr dereference in dev_pm_opp_get_required_pstate()

"opp" pointer is dereferenced before the IS_ERR_OR_NULL() check. Fix it by
removing the dereference to cache opp_table and dereference it directly
where opp_table is used.

This fixes the following smatch warning:

drivers/opp/core.c:232 dev_pm_opp_get_required_pstate() warn: variable
dereferenced before IS_ERR check 'opp' (see line 230)

Fixes: 84cb7ff35fcf ("OPP: pstate is only valid for genpd OPP tables")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/opp/core.c