OSDN Git Service

drm/mipi-dbi: Remove ->enabled
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 12 Jun 2020 16:00:55 +0000 (18:00 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 24 Jun 2020 07:17:34 +0000 (09:17 +0200)
commit7e06886bbfca73717e45a0f20cdb4053793c191b
tree4608d9633f9afd2b2d69e83a65060c89d7e667c0
parente8411b7ede3bd59f45a7ad997536d235e9c71c36
drm/mipi-dbi: Remove ->enabled

The atomic helpers try really hard to not lose track of things,
duplicating enabled tracking in the driver is at best confusing.
Double-enabling or disabling is a bug in atomic helpers.

In the fb_dirty function we can just assume that the fb always exists,
simple display pipe helpers guarantee that the crtc is only enabled
together with the output, so we always have a primary plane around.

Now in the update function we need to be a notch more careful, since
that can also get called when the crtc is off. And we don't want to
upload frames when that's the case, so filter that out too.

Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: David Lechner <david@lechnology.com>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Lechner <david@lechnology.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200612160056.2082681-7-daniel.vetter@ffwll.ch
drivers/gpu/drm/drm_mipi_dbi.c
drivers/gpu/drm/tiny/ili9225.c
drivers/gpu/drm/tiny/st7586.c
include/drm/drm_mipi_dbi.h