OSDN Git Service

e1000e: driver trying to free already-free irq
authorkhalidm <khalidm@cisco.com>
Mon, 17 Oct 2016 16:51:08 +0000 (09:51 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Fri, 6 Jan 2017 10:18:49 +0000 (02:18 -0800)
commit7e54d9d063fa239c95c21548c5267f0ef419ff56
tree44ce38bf4a7e2652051e37a438647ab7d1904630
parent030ec9e68239a8b7851701edc29de5745fe15024
e1000e: driver trying to free already-free irq

During systemd reboot sequence network driver interface is shutdown
by e1000_close. The PCI driver interface is shut by e1000_shutdown.
The e1000_shutdown checks for netif_running status, if still up it
brings down driver. But it disables msi outside of this if statement,
regardless of netif status. All this is OK when e1000_close happens
after shutdown. However, by default, everything in systemd is done
in parallel. This creates a conditions where e1000_shutdown is called
after e1000_close, therefore hitting BUG_ON assert in free_msi_irqs.

CC: xe-kernel@external.cisco.com
Signed-off-by: khalidm <khalidm@cisco.com>
Signed-off-by: David Singleton <davsingl@cisco.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e1000e/netdev.c