OSDN Git Service

net: fec: properly guard irq coalesce setup
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Mon, 5 Dec 2022 20:46:04 +0000 (21:46 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 7 Dec 2022 04:22:34 +0000 (20:22 -0800)
commit7e6303567ce3ca506e4a2704e4baa86f1d8bde02
treeabe730ff9daff2785cf6138e35d0b828822ce68d
parent1f154f3b56a1a172833eedf77b72745acc8d9259
net: fec: properly guard irq coalesce setup

Prior to the Fixes: commit, the initialization code went through the
same fec_enet_set_coalesce() function as used by ethtool, and that
function correctly checks whether the current variant has support for
irq coalescing.

Now that the initialization code instead calls fec_enet_itr_coal_set()
directly, that call needs to be guarded by a check for the
FEC_QUIRK_HAS_COALESCE bit.

Fixes: df727d4547de (net: fec: don't reset irq coalesce settings to defaults on "ip link up")
Reported-by: Greg Ungerer <gregungerer@westnet.com.au>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20221205204604.869853-1-linux@rasmusvillemoes.dk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fec_main.c