OSDN Git Service

pstore: Convert console write to use ->write_buf
authorNamhyung Kim <namhyung@kernel.org>
Wed, 19 Oct 2016 01:23:41 +0000 (10:23 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 20:55:12 +0000 (21:55 +0100)
commit7f0324fb34c4736bf12ae8a5137e6913772749cc
treedb63906729c6d3155ec5ecbd0b34c1f6c9e81363
parent466570dc30cf556a0f27c9d823341e249b2000a9
pstore: Convert console write to use ->write_buf

[ Upstream commit 70ad35db3321a6d129245979de4ac9d06eed897c ]

Maybe I'm missing something, but I don't know why it needs to copy the
input buffer to psinfo->buf and then write.  Instead we can write the
input buffer directly.  The only implementation that supports console
message (i.e. ramoops) already does it for ftrace messages.

For the upcoming virtio backend driver, it needs to protect psinfo->buf
overwritten from console messages.  If it could use ->write_buf method
instead of ->write, the problem will be solved easily.

Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/pstore/platform.c