OSDN Git Service

drm/i915/guc: Fix doorbell id selection
authorMichel Thierry <michel.thierry@intel.com>
Wed, 31 May 2017 00:05:46 +0000 (17:05 -0700)
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Wed, 31 May 2017 07:34:03 +0000 (10:34 +0300)
commit7f1ea2ac30171d9a6aad2916a73e41fa68c8f137
tree9cf32486ec656fd14eab9dedfbf120d28fc3c94b
parentbef8c056fba09aa4629fe5a2d3efe64068d049db
drm/i915/guc: Fix doorbell id selection

We are passing parameters in the wrong order to find next zero bit, and
when it doesn't find anything it returns size (offset in the code), which
is always zero.

For reference the function is defined as:
find_next_bit( *addr, size, offset )

The incorrect parameter order was added by commit abddffdf3620e
("drm/i915/guc: Sanitize GuC client initialization"). Luckily, currently
we only use a single guc client and a single doorbell, which happens to be
zero; therefore it isn't necessary to backport this fix (which would be for
v4.12).

Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Oscar Mateo <oscar.mateo@intel.com>
Signed-off-by: Michel Thierry <michel.thierry@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170531000546.30762-1-michel.thierry@intel.com
drivers/gpu/drm/i915/i915_guc_submission.c