OSDN Git Service

drm/amd/powerplay/smu8_hwmgr: use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 19 Feb 2019 18:42:32 +0000 (12:42 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 19 Feb 2019 20:58:27 +0000 (15:58 -0500)
commit7f5725f9802502651644e874bb9a59e66215839d
treee043fe895c62dbbbcc3664a077f9b16fcce3062d
parentd6001aed266391e05517ff03078c144d4b279d5d
drm/amd/powerplay/smu8_hwmgr: use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

size = sizeof(struct foo) + count * sizeof(struct boo);
instance = kzalloc(size, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

Notice that, in this case, variable table_size is not necessary, hence
it is removed.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c