OSDN Git Service

PCI: Bus number from the bridge, not the device
authorAlex Williamson <alex.williamson@redhat.com>
Mon, 4 Oct 2010 21:53:11 +0000 (15:53 -0600)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 16 Nov 2010 12:53:43 +0000 (14:53 +0200)
commit7f5feab4dda39b39dce24113313587587aa2d0ab
treee501dabbdc3616b25fb52079b8b03efc28cc4308
parente685b4eb649cbddd26f203b611eabeb714648f4d
PCI: Bus number from the bridge, not the device

pcibus_dev_print() was erroneously retrieving the device bus
number from the secondary bus number offset of the device
instead of the bridge above the device.  This ends of landing
in the 2nd byte of the 3rd BAR for devices, which thankfully
is usually zero.

Note: pcibus_get_dev_path() copied this code,
inheriting the same bug.  pcibus_get_dev_path() is used for
ramblock naming, so changing it can effect migration.  However,
I've only seen this byte be non-zero for an assigned device,
which can't migrate anyway, so hopefully we won't run into
any issues.

This patch does not touch pcibus_get_dev_path, as
bus number is guest assigned for nested buses,
so using it for migration is broken anyway.
Fix it properly later.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/pci.c