OSDN Git Service

staging: ccree: Use platform_get_irq and devm_request_irq
authorSuniel Mahesh <sunil.m@techveda.org>
Thu, 7 Sep 2017 09:00:11 +0000 (12:00 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Sep 2017 14:35:25 +0000 (16:35 +0200)
commit7f6f832d258a1b411dcc3ba9345ed3036fe05ca5
treec35c8e4fb5969918b5ed892c66981f0cd68f87ff
parentce58df6394c2a830ca184c2e9fe8d1bb425a665a
staging: ccree: Use platform_get_irq and devm_request_irq

It is recommended to use managed function devm_request_irq(),
which simplifies driver cleanup paths and driver code.
This patch does the following:
(a) replace platform_get_resource(), request_irq() and corresponding
error handling with platform_get_irq() and devm_request_irq().
(b) remove struct resource pointer(res_irq) in struct ssi_drvdata as
it seems redundant.
(c) change type of member irq in struct ssi_drvdata from unsigned int
to int, as return type of platform_get_irq is int and can be used in
error handling.
(d) remove irq_registered variable from driver probe as it seems
redundant.
(e) free_irq is not required any more, devm_request_irq() free's it
on driver detach.
(f) adjust log messages accordingly and remove any blank lines.

Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ccree/ssi_driver.c
drivers/staging/ccree/ssi_driver.h