OSDN Git Service

ravb: Add missing free_irq() call to ravb_close()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Sat, 7 May 2016 11:17:11 +0000 (13:17 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 May 2016 02:30:39 +0000 (22:30 -0400)
commit7fa816b92c52e2c304f2ff6401e0d51e1d229ca5
tree6765347fe918d9844ca56d80ed75e5cc3024f7ac
parent4a91cb61bb995e5571098188092e296192309c77
ravb: Add missing free_irq() call to ravb_close()

When reopening the network device on ra7795/salvator-x, e.g. after a
DHCP timeout:

    IP-Config: Reopening network devices...
    genirq: Flags mismatch irq 139. 00000000 (eth0:ch24:emac) vs. 00000000 (eth0:ch24:emac)
    ravb e6800000.ethernet eth0: cannot request IRQ eth0:ch24:emac
    IP-Config: Failed to open eth0
    IP-Config: No network devices available

The "mismatch" is due to requesting an IRQ that is already in use,
while IRQF_PROBE_SHARED wasn't set.

However, the real cause is that ravb_close() doesn't release the R-Car
Gen3-specific secondary IRQ.

Add the missing free_irq() call to fix this.

Fixes: 22d4df8ff3a3cc72 ("ravb: Add support for r8a7795 SoC")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/ravb_main.c