OSDN Git Service

scsi: qla2xxx: Fix a memory leak in an error path of qla2x00_process_els()
authorJoy Gu <jgu@purestorage.com>
Tue, 12 Oct 2021 19:18:33 +0000 (12:18 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 19 Oct 2021 03:04:31 +0000 (23:04 -0400)
commit7fb223d0ad801f633c78cbe42b1d1b55f5d163ad
tree9bf53811ef933dee9516b04bd10dbd675300c93b
parent06634d5b6e923ed0d4772aba8def5a618f44c7fe
scsi: qla2xxx: Fix a memory leak in an error path of qla2x00_process_els()

Commit 8c0eb596baa5 ("[SCSI] qla2xxx: Fix a memory leak in an error path of
qla2x00_process_els()"), intended to change:

        bsg_job->request->msgcode == FC_BSG_HST_ELS_NOLOGIN

to:

        bsg_job->request->msgcode != FC_BSG_RPT_ELS

but changed it to:

        bsg_job->request->msgcode == FC_BSG_RPT_ELS

instead.

Change the == to a != to avoid leaking the fcport structure or freeing
unallocated memory.

Link: https://lore.kernel.org/r/20211012191834.90306-2-jgu@purestorage.com
Fixes: 8c0eb596baa5 ("[SCSI] qla2xxx: Fix a memory leak in an error path of qla2x00_process_els()")
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Joy Gu <jgu@purestorage.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_bsg.c