OSDN Git Service

fbdev: da8xx-fb: go to proper label on error handling paths in probe
authorEvgeny Novikov <novikov@ispras.ru>
Thu, 2 Jul 2020 16:05:40 +0000 (19:05 +0300)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Fri, 10 Jul 2020 14:17:28 +0000 (16:17 +0200)
commit80a00e90dedec514686ac1eb7e7b8e60e1d9aec9
tree8b1bdad8d2d2c98b5de5d6b86ac949c32fca83d9
parent9907797a09d23182aa36479dac6f28defcfb2714
fbdev: da8xx-fb: go to proper label on error handling paths in probe

fb_probe() can successfully allocate a new frame buffer, but then fail
to perform some operations with regulator. In these cases fb_probe()
goes to label err_pm_runtime_disable where the frame buffer is not
released. The patch makes fb_probe() to go to label err_release_fb on
corresponding error handling paths.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200702160540.24546-1-novikov@ispras.ru
drivers/video/fbdev/da8xx-fb.c