OSDN Git Service

locktorture: Print ratio of acquisitions, not failures
authorPaul E. McKenney <paulmck@kernel.org>
Thu, 23 Jan 2020 17:19:01 +0000 (09:19 -0800)
committerPaul E. McKenney <paulmck@kernel.org>
Thu, 20 Feb 2020 23:59:59 +0000 (15:59 -0800)
commit80c503e0e68fbe271680ab48f0fe29bc034b01b7
tree0cb58bcf7d475c1bdf7fd1d477b2fb20bbe8cb22
parentbb6d3fb354c5ee8d6bde2d576eb7220ea09862b9
locktorture: Print ratio of acquisitions, not failures

The __torture_print_stats() function in locktorture.c carefully
initializes local variable "min" to statp[0].n_lock_acquired, but
then compares it to statp[i].n_lock_fail.  Given that the .n_lock_fail
field should normally be zero, and given the initialization, it seems
reasonable to display the maximum and minimum number acquisitions
instead of miscomputing the maximum and minimum number of failures.
This commit therefore switches from failures to acquisitions.

And this turns out to be not only a day-zero bug, but entirely my
own fault.  I hate it when that happens!

Fixes: 0af3fe1efa53 ("locktorture: Add a lock-torture kernel module")
Reported-by: Will Deacon <will@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Acked-by: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Peter Zijlstra <peterz@infradead.org>
kernel/locking/locktorture.c