OSDN Git Service

llc: use refcount_inc_not_zero() for llc_sap_find()
authorCong Wang <xiyou.wangcong@gmail.com>
Tue, 7 Aug 2018 19:41:38 +0000 (12:41 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Aug 2018 05:48:35 +0000 (07:48 +0200)
commit813fb06fe60d0a56a5481fb81793142fc00bf4bd
tree7f36db7fda6670d11e46c4f0d940b287370831fe
parent4aef9b0fffd2295b1c523ebf43ca6b46e9cc8ffa
llc: use refcount_inc_not_zero() for llc_sap_find()

[ Upstream commit 0dcb82254d65f72333aa50ad626d1e9665ad093b ]

llc_sap_put() decreases the refcnt before deleting sap
from the global list. Therefore, there is a chance
llc_sap_find() could find a sap with zero refcnt
in this global list.

Close this race condition by checking if refcnt is zero
or not in llc_sap_find(), if it is zero then it is being
removed so we can just treat it as gone.

Reported-by: <syzbot+278893f3f7803871f7ce@syzkaller.appspotmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/net/llc.h
net/llc/llc_core.c