OSDN Git Service

crypto: drbg - Fix unused value warning in drbg_healthcheck_sanity()
authorTim Gardner <tim.gardner@canonical.com>
Fri, 10 Sep 2021 19:01:17 +0000 (13:01 -0600)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 17 Sep 2021 03:06:15 +0000 (11:06 +0800)
commit81f53028dfbc79844f727a7c13d337ba827a471c
tree3d1a40f0ad19bf24b7071037ee8401e0d0f1240f
parent5e91f56a0bb32fd14096e20224bf4f93f1b174b1
crypto: drbg - Fix unused value warning in drbg_healthcheck_sanity()

Coverity warns uf an unused value:

CID 44865 (#2 of 2): Unused value (UNUSED_VALUE)
assigned_value: Assigning value -14 to ret here, but that stored value is
overwritten before it can be used.
2006        int ret = -EFAULT;
...
value_overwrite: Overwriting previous write to ret with value from drbg_seed(drbg, &addtl, false).
2052        ret = drbg_seed(drbg, &addtl, false);

Fix this by removing the variable initializer.

Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/drbg.c