OSDN Git Service

MIPS: uprobes: remove incorrect set_orig_insn
authorMarcin Nowakowski <marcin.nowakowski@imgtec.com>
Thu, 22 Sep 2016 13:38:32 +0000 (15:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Oct 2016 13:23:42 +0000 (15:23 +0200)
commit824865e1f7ade5766d45f7f2a1584a0f5b00bf91
tree81e949fb58f9ad92b0027fa52998eee92aa2b5f6
parent9b228c19dd2099ff0cb8f6643cede8ac9272a5e2
MIPS: uprobes: remove incorrect set_orig_insn

commit ddabfa5c2e33f1b495f3e0176de7057850915c0b upstream.

Generic kernel code implements a weak version of set_orig_insn that
moves cached 'insn' from arch_uprobe to the original code location when
the trap is removed.
MIPS variant used arch_uprobe->orig_inst which was never initialised
properly, so this code only inserted a nop instead of the original
instruction. With that change orig_inst can also be safely removed.

Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Fixes: 40e084a506eb ('MIPS: Add uprobes support.')
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/14299/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/mips/include/asm/uprobes.h
arch/mips/kernel/uprobes.c