OSDN Git Service

drm/amdgpu: Fix bounds checking in amdgpu_ras_is_supported()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 8 Jun 2019 09:23:57 +0000 (12:23 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 11 Jun 2019 17:51:51 +0000 (12:51 -0500)
commit8252562d5270c13e6123a5939d0db1bbf04327a1
tree3b2ecfd1c87f2a7f4425592aea6cd3b12b225a54
parent9c5ab937b15f87523dd057ba05b9869331283286
drm/amdgpu: Fix bounds checking in amdgpu_ras_is_supported()

The "block" variable can be set by the user through debugfs, so it can
be quite large which leads to shift wrapping here.  This means we report
a "block" as supported when it's not, and that leads to array overflows
later on.

This bug is not really a security issue in real life, because debugfs is
generally root only.

Fixes: 36ea1bd2d084 ("drm/amdgpu: add debugfs ctrl node")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h