OSDN Git Service

signal/arm64: Use force_sig not force_sig_fault for SIGKILL
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 16 May 2019 15:55:21 +0000 (10:55 -0500)
committerEric W. Biederman <ebiederm@xmission.com>
Mon, 27 May 2019 14:36:27 +0000 (09:36 -0500)
commit82e10af2248d2d09c99834613f1b47d5002dc379
tree4a60fcac51f5cb91957465aea4726dfad68ef6f8
parent7a0cf094944e2540758b7f957eb6846d5126f535
signal/arm64: Use force_sig not force_sig_fault for SIGKILL

I don't think this is userspace visible but SIGKILL does not have
any si_codes that use the fault member of the siginfo union.  Correct
this the simple way and call force_sig instead of force_sig_fault when
the signal is SIGKILL.

The two know places where synchronous SIGKILL are generated are
do_bad_area and fpsimd_save.  The call paths to force_sig_fault are:
do_bad_area
  arm64_force_sig_fault
    force_sig_fault
force_signal_inject
  arm64_notify_die
    arm64_force_sig_fault
       force_sig_fault

Which means correcting this in arm64_force_sig_fault is enough
to ensure the arm64 code is not misusing the generic code, which
could lead to maintenance problems later.

Cc: stable@vger.kernel.org
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: James Morse <james.morse@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Fixes: af40ff687bc9 ("arm64: signal: Ensure si_code is valid for all fault signals")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
arch/arm64/kernel/traps.c