OSDN Git Service

PCI: dwc: Use interrupt masking instead of disabling
authorMarc Zyngier <marc.zyngier@arm.com>
Tue, 13 Nov 2018 22:57:32 +0000 (22:57 +0000)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Tue, 11 Dec 2018 10:37:13 +0000 (10:37 +0000)
commit830920e065e90db318a0da98bf13a02b641eae7f
treee86e65c8c848e45a72f75bd863a4bb7b253b3c0c
parent651022382c7f8da46cb4872a545ee1da6d097d2a
PCI: dwc: Use interrupt masking instead of disabling

The dwc driver is showing an interesting level of brokeness, as it
insists on using the enable/disable set of registers to mask/unmask
MSIs, meaning that an MSIs being generated while the interrupt is in
that "disabled" state will simply be lost.

Let's move to the mask/unmask set of registers, which offers the
expected semantics.

Fixes: 7c5925afbc58 ("PCI: dwc: Move MSI IRQs allocation to IRQ domains
hierarchical API")
Link: https://lore.kernel.org/linux-pci/20181113225734.8026-1-marc.zyngier@arm.com/
Tested-by: Niklas Cassel <niklas.cassel@linaro.org>
Tested-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Tested-by: Stanimir Varbanov <svarbanov@mm-sol.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
[lorenzo.pieralisi@arm.com: updated commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: stable@vger.kernel.org
drivers/pci/controller/dwc/pcie-designware-host.c