OSDN Git Service

media: usbvision: constify i2c_algorithm structure
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Sun, 9 Jul 2017 22:04:24 +0000 (18:04 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Thu, 20 Jul 2017 18:53:00 +0000 (14:53 -0400)
commit830a45a2f44852fb7e1b49f95c7c5703816d9d94
treedaad8d7cab22c98b7c65cccb3b90cb36d6181f56
parent8d08a4c1aae8857c46079d329023753611218518
media: usbvision: constify i2c_algorithm structure

Check for i2c_algorithm structures that are only stored in
the algo field of an i2c_adapter structure. This field is
declared const, so i2c_algorithm structures that have this
property can be declared as const also.

This issue was identified using Coccinelle and the following
semantic patch:

@r disable optional_qualifier@
identifier i;
position p;
@@
static struct i2c_algorithm i@p = { ... };

@ok@
identifier r.i;
struct i2c_adapter e;
position p;
@@
e.algo = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct i2c_algorithm i = { ... };

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/usbvision/usbvision-i2c.c