OSDN Git Service

drm/amdgpu: don't invalidate caches in RELEASE_MEM, only do the writeback
authorMarek Olšák <marek.olsak@amd.com>
Fri, 28 Jun 2019 22:31:26 +0000 (18:31 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 9 Jul 2019 22:43:09 +0000 (17:43 -0500)
commit83145f110eb2ada9d54fcbcf416c02de126381c1
tree5cbad266500e8f9b9d05a871aff1966512d7627b
parent5f65ae344f1493c9c6f0a1748da4ce3af71ab541
drm/amdgpu: don't invalidate caches in RELEASE_MEM, only do the writeback

This RELEASE_MEM use has the Release semantic, which means we should write
back but not invalidate. Invalidations only make sense with the Acquire
semantic (ACQUIRE_MEM), or when RELEASE_MEM is used to do the combined
Acquire-Release semantic, which is a barrier, not a fence.

The undesirable side effect of doing invalidations for the Release semantic
is that it invalidates caches while shaders are running, because the Release
can execute in the middle of the next IB.

UMDs should use ACQUIRE_MEM at the beginning of IBs. Doing cache
invalidations for a fence (like in this case) doesn't do anything
for correctness.

Signed-off-by: Marek Olšák <marek.olsak@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c