OSDN Git Service

Add newline inside new root elements, and some move code around
authorTor Norbye <tnorbye@google.com>
Fri, 18 Mar 2011 02:59:38 +0000 (19:59 -0700)
committerTor Norbye <tnorbye@google.com>
Mon, 21 Mar 2011 19:24:15 +0000 (12:24 -0700)
commit842b0eb9e2d530c19b9af3981e2d688411c1e554
tree72d00bfdcbb2d4e4431f51efa43b6ac7a8c549f5
parentf3161ca5f88bc9a5660054575ead0c3feed6b314
Add newline inside new root elements, and some move code around

Tweak the "New XML File" creation code to insert a new line inside the
created root element, indent, and place the cursor there.  This means
that you end up with:

    <LinearLayout>
        |
    </LinearLayout>

instead of (where | denotes the initial caret position):

   |<LinearLayout>
    </LinearLayout>

This means you can instantly press Ctrl-Space to complete on the
elements, etc., and is similar to how Eclipse creates new method
bodies from templates, adding newlines such that you can instantly
write code there instead of having to "open them up".

All the diffs for this are in NewXmlFileWizard.java; the other
modifications in this changeset are simple move refactoring
operations as described next:

The second change in this changeset is moving some code around such
that common utility methods live in more natural places rather than
where they were first needed.

In particular:
Hyperlinks.openUrl                             => AdtPlugin
Hyperlinks.openJavaClass                       => AdtPlugin
Hyperlinks.openFile                            => AdtPlugin
AndroidContentAssist.getAndroidXmlEditor       => AndroidXmlEditor
ResourceChooser.canCreateResource              => ResourceHelper
ResourceChooser.createResource                 => ResourceHelper
Hyperlinks.parseResource                       => ResourceHelper
ResourceNameValidator.isValueBasedResourceType => ResourceHelper
ResourceNameValidator.isFileBasedResourceType  => ResourceHelper

Change-Id: If7690df9ce59c709c1d909ffd9f74c2684f3dd46
14 files changed:
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/AdtPlugin.java
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/build/AaptQuickFix.java
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/editors/AndroidContentAssist.java
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/editors/AndroidXmlEditor.java
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/editors/layout/gle2/GraphicalEditorPart.java
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/editors/layout/gle2/PaletteControl.java
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/editors/xml/Hyperlinks.java
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/resources/ResourceHelper.java
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/resources/ResourceNameValidator.java
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/ui/ResourceChooser.java
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/wizards/newxmlfile/NewXmlFileWizard.java
eclipse/plugins/com.android.ide.eclipse.tests/src/com/android/ide/eclipse/adt/internal/editors/layout/refactoring/testdata/quickfix1-expected-quickFix3.xml
eclipse/plugins/com.android.ide.eclipse.tests/unittests/com/android/ide/eclipse/adt/internal/resources/ResourceHelperTest.java
eclipse/plugins/com.android.ide.eclipse.tests/unittests/com/android/ide/eclipse/adt/internal/resources/ResourceNameValidatorTest.java