OSDN Git Service

ahci: fix win7 hang on boot
authorAlexander Graf <agraf@suse.de>
Mon, 28 Oct 2013 19:01:51 +0000 (21:01 +0200)
committerKevin Wolf <kwolf@redhat.com>
Tue, 29 Oct 2013 12:06:39 +0000 (13:06 +0100)
commit8464b273d69c61e33c55347e5b6bc0659687bae2
tree6dc2feb1d64442a3ec23cf9fe7e4e335cd398c61
parent1841f8801c8898fa57c66e27a08541ffcc6f3948
ahci: fix win7 hang on boot

When AHCI executes an asynchronous IDE command, it checked DRDY without
checking either DRQ or BSY.  This sometimes caused interrupt to be sent
before command is actually completed.

This resulted in a race condition: if guest then managed to access the
device before command has completed, it would hang waiting for an
interrupt.
This was observed with windows 7 guests.

To fix, check for DRQ or BSY in additiona to DRDY, if set,
the command is asynchronous so delay the interrupt until
asynchronous done callback is invoked.

Reported-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
hw/ide/ahci.c