OSDN Git Service

net: Initialize all members in skb_gro_remcsum_init()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Wed, 18 Feb 2015 10:38:06 +0000 (11:38 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Feb 2015 20:49:57 +0000 (15:49 -0500)
commit846cd66788b11105a62785078360c8854aa98310
tree9c96b48df38f8e5804e177ae6b00ab57abfb31cd
parentf81edc6ac1e1e2e2cbe98bcd6ef5ebb7afb00807
net: Initialize all members in skb_gro_remcsum_init()

skb_gro_remcsum_init() initializes the gro_remcsum.delta member only,
leading to compiler warnings about a possibly uninitialized
gro_remcsum.offset member:

drivers/net/vxlan.c: In function ‘vxlan_gro_receive’:
drivers/net/vxlan.c:602: warning: ‘grc.offset’ may be used uninitialized in this function
net/ipv4/fou.c: In function ‘gue_gro_receive’:
net/ipv4/fou.c:262: warning: ‘grc.offset’ may be used uninitialized in this function

While these are harmless for now:
  - skb_gro_remcsum_process() sets offset before changing delta,
  - skb_gro_remcsum_cleanup() checks if delta is non-zero before
    accessing offset,
it's safer to let the initialization function initialize all members.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Tom Herbert <therbert@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netdevice.h