OSDN Git Service

arm64: entry.S: Remove disable_dbg
authorJames Morse <james.morse@arm.com>
Thu, 2 Nov 2017 12:12:38 +0000 (12:12 +0000)
committerWill Deacon <will.deacon@arm.com>
Thu, 2 Nov 2017 15:55:41 +0000 (15:55 +0000)
commit84d0fb1bb6257d5d5d45f5e3554ab441b4ff5a74
tree3054c4b315f1b3963b0ceeeeea140f6d85503933
parent8d66772e869e79ffb94eed7492ca3d2267e150e8
arm64: entry.S: Remove disable_dbg

enable_step_tsk is the only user of disable_dbg, which doesn't respect
our 'dai' order for exception masking. enable_step_tsk may enable
single-step, so previously needed to mask debug exceptions to prevent us
from single-stepping kernel_exit. enable_step_tsk is called at the end
of the ret_to_user loop, which has already masked all exceptions so this
is no longer needed.

Remove disable_dbg, add a comment that enable_step_tsk's caller should
have masked debug.

Signed-off-by: James Morse <james.morse@arm.com>
Reviewed-by: Julien Thierry <julien.thierry@arm.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/include/asm/assembler.h