OSDN Git Service

iomap: Make sure iomap_end is called after iomap_begin
authorAndreas Gruenbacher <agruenba@redhat.com>
Mon, 6 Jul 2020 17:49:27 +0000 (10:49 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Mon, 6 Jul 2020 17:49:27 +0000 (10:49 -0700)
commit856473cd5d17dbbf3055710857c67a4af6d9fcc0
tree685894fe5991fa5fd5358353631ea9c565fdaf62
parentdcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258
iomap: Make sure iomap_end is called after iomap_begin

Make sure iomap_end is always called when iomap_begin succeeds.

Without this fix, iomap_end won't be called when a filesystem's
iomap_begin operation returns an invalid mapping, bypassing any
unlocking done in iomap_end.  With this fix, the unlocking will still
happen.

This bug was found by Bob Peterson during code review.  It's unlikely
that such iomap_begin bugs will survive to affect users, so backporting
this fix seems unnecessary.

Fixes: ae259a9c8593 ("fs: introduce iomap infrastructure")
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/iomap/apply.c