OSDN Git Service

media: atomisp: print a better message when fw version is wrong
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 7 May 2020 16:33:29 +0000 (18:33 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 20 May 2020 10:32:20 +0000 (12:32 +0200)
commit8568fe630066a733456fb1ffc8e1402191d7e27c
tree12139f606bc6d592f26a84f029fd79762efccdd0
parent1ab709827c08619c7b2401ea7e0769a9b70846fe
media: atomisp: print a better message when fw version is wrong

The printed message when a firmware version is wrong says nothing
usefull:

atomisp-isp2 0000:00:03.0: Fw version check failed.
atomisp-isp2: probe of 0000:00:03.0 failed with error -22

Print the expected and the received firmware version instead.

In order to do that, the firmware functions will need at least
a struct device pointer, so pass it.

While writing this patch, it was noticed that some of the
abstraction layers of this driver have functions that are never
called, but use this interface. Get rid of them.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
drivers/staging/media/atomisp/pci/ia_css_control.h
drivers/staging/media/atomisp/pci/ia_css_firmware.h
drivers/staging/media/atomisp/pci/sh_css.c
drivers/staging/media/atomisp/pci/sh_css_firmware.c
drivers/staging/media/atomisp/pci/sh_css_firmware.h