OSDN Git Service

l2tp: purge socket queues in the .destruct() callback
authorGuillaume Nault <g.nault@alphalink.fr>
Wed, 29 Mar 2017 06:45:29 +0000 (08:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 May 2017 04:19:51 +0000 (21:19 -0700)
commit8625dfcfd338254131a7fa650dfbcaf42e4c52ae
treedba6e061a8d03a994a8c835eb9e4e8d226a762e3
parent0e9eeb4676a770acf0d97c93db77bcbdad4eefc5
l2tp: purge socket queues in the .destruct() callback

[ Upstream commit e91793bb615cf6cdd59c0b6749fe173687bb0947 ]

The Rx path may grab the socket right before pppol2tp_release(), but
nothing guarantees that it will enqueue packets before
skb_queue_purge(). Therefore, the socket can be destroyed without its
queues fully purged.

Fix this by purging queues in pppol2tp_session_destruct() where we're
guaranteed nothing is still referencing the socket.

Fixes: 9e9cb6221aa7 ("l2tp: fix userspace reception on plain L2TP sockets")
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/l2tp/l2tp_ppp.c