OSDN Git Service

ibmvnic: fix: NULL pointer dereference.
authorYANG LI <abaci-bugfix@linux.alibaba.com>
Wed, 30 Dec 2020 07:23:14 +0000 (15:23 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 4 Jan 2021 21:23:33 +0000 (13:23 -0800)
commit862aecbd9569e563b979c0e23a908b43cda4b0b9
tree14b330efc3569d4c721f9439dfe93b76e6851cb2
parente4da63cda51f17fa1e86a10e84d47d692932530d
ibmvnic: fix: NULL pointer dereference.

The error is due to dereference a null pointer in function
reset_one_sub_crq_queue():

if (!scrq) {
    netdev_dbg(adapter->netdev,
               "Invalid scrq reset. irq (%d) or msgs(%p).\n",
scrq->irq, scrq->msgs);
return -EINVAL;
}

If the expression is true, scrq must be a null pointer and cannot
dereference.

Fixes: 9281cf2d5840 ("ibmvnic: avoid memset null scrq msgs")
Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
Reported-by: Abaci <abaci@linux.alibaba.com>
Acked-by: Lijun Pan <ljp@linux.ibm.com>
Link: https://lore.kernel.org/r/1609312994-121032-1-git-send-email-abaci-bugfix@linux.alibaba.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/ibmvnic.c