OSDN Git Service

uio/uio_pci_generic: Disable bus-mastering on release
authorVenkatesh Srinivas <venkateshs@google.com>
Wed, 23 Jan 2019 11:27:51 +0000 (11:27 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 31 Jan 2019 15:22:51 +0000 (16:22 +0100)
commit865a11f987ab5f03089b2728420b61a2a1f7051a
tree297392fb063a48e7b8faa6db2759453703dc6030
parente5bae74338b37fb88d33d7c18acb694670c24b09
uio/uio_pci_generic: Disable bus-mastering on release

Userspace code using uio_pci_generic may enable bus-mastering by
directly manipulating a PCI device's command register. If a userspace
program enables bus-mastering but exits/crashes uncleanly, bus-
mastering will still be enabled and stale DMA addresses may be
programmed and live in the device.

Disable bus-mastering unconditionally on last close of a UIO PCI fd
to avoid this. If the device did not have bus-mastering enabled,
pci_clear_master() is a no-op.

Signed-off-by: Venkatesh Srinivas <venkateshs@google.com>
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Catherine Sullivan <csully@google.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/uio/uio_pci_generic.c