OSDN Git Service

perf annotate: Prevent overflow in size calculation
authorCody Schafer <cody@linux.vnet.ibm.com>
Fri, 20 Jul 2012 03:05:25 +0000 (20:05 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 25 Jul 2012 16:06:42 +0000 (13:06 -0300)
commit8696329b7bcf32e69ad12d5975ad1497936d43ec
tree7bf0b93bf0daf91b9b8b9a655230bb6f92b433e1
parent52f18a2ff9b012a7efdbd520ca0dc0e118a8a837
perf annotate: Prevent overflow in size calculation

A large enough symbol size causes an overflow in the size parameter to
the histogram allocation, leading to a segfault in
symbol__inc_addr_samples later on when this histogram is accessed.

In the case of being called via perf-report, this returns back and
gracefully ignores the sample, eventually ignoring the chained return
value of perf_session_deliver_event in flush_sample_queue.

Signed-off-by: Cody Schafer <cody@linux.vnet.ibm.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1342753525-4521-1-git-send-email-cody@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/annotate.c